Bad regex in filters.txt

[timsayshey]

There is a regex in filters.txt on line 24380 and it's not clear what the regex filter is doing but it is randomly blocking legit scripts on different websites that I visit.

/^https?:\/\/[a-z]{7,15}\.(?:com|pw)\/[0-9a-zA-Z]{11,17}\/\d{4,5}$/$script,3p

There is no comment explaining what it does or why it is there.

I propose that it be removed.

Please advise.

[uBlock-user]

but it is randomly blocking legit scripts on different websites that I visit.

Example ?

[mapx-]

reason: easylist/easylist#6476

Provide ALL the pages you found where legitimate stuff is blocked

[timsayshey]

Okay, here's one where there should be an ecard widget displaying on the page but it's being blocked arbitrarily by this mess of a regex. There will be many unintended consequences for a regex like this.

Here's the site:
https://americanpatriotsunsung.com/thank-a-vet/

[mapx-]

@Yuki2718 first FP

[Yuki2718]

@timsayshey Sincere apology for inconvenience. It was added to beat revolving ad scripts but I now see it should be adjusted more carefully.
@mapx- Can you turn it off temporary?

[Yuki2718]

@timsayshey Hi, can you give us some more examples of breakage? Fixing the regex to avoid the breakage on americanpatriotsunsung will be possible, but I want to ensure the fix doesn't break other pages. The thing is these ad server the filter targeted changes so frequently that chasing them is not trivial.

[mapx-]

@Yuki2718 test this 1:

/^https?:\/\/[a-z]{7,15}\.(?:com|pw)\/([a-z]+[0-9]+[A-Z]).{11,17}\/\d{4,5}/$script,3p

[Yuki2718]

@mapx- Sorry, I have a working solution of /^https?:\/\/[a-z]{7,15}\.(?:com|pw)\/(?=[0-9A-Z]{0,16}[a-z])(?=[0-9a-z]{0,16}[A-Z])[0-9a-zA-Z]{11,17}\/\d{4,5}$/$script,3p it's best because doesn't care which order they appear, and also there's a case not including any number. Just waiting the OP's example of other breakage.

[mapx-]

yours does not work:

[Yuki2718]

@mapx- You're right, and apparently the reason is somehow uBO's regex interpretation is case-insensitive. I also observed the case insensitivity on easylist/easylist#6537 Pinging @gorhill for a possible bug.
As an evidence, /^https?:\/\/[a-z]{7,15}\.(?:com|pw)\/(?=[0-9A-Z]{0,16}[a-z])(?=[a-zA-Z]{0,16}[0-9])[0-9a-zA-Z]{11,17}\/\d{4,5}$/$script,3p
(includes at least one number, instead of capital letter) correctly allow the script.

[mapx-]

So, again, did you test my filter ?