fix(quick-edit): add missing variable scope to solarflare light theme
#11515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Light theme was missing the base `variable` scope in the Variables rule, causing JS/TS variables to fall back to the default editor foreground color (#62676A gray) instead of being highlighted. The dark theme correctly had `variable` which matches all variable.* tokens via TextMate prefix matching. The light theme only had `variable.other` which doesn't match plain `variable` scoped tokens. Also removes duplicate `variable.other.object` entries from both themes.
🦋 Changeset detectedLatest commit: a6d599c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dmmulroy
changed the title
variable scope to light themevariable scope to solarflare light theme
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
jamesopstad
approved these changes
Dec 3, 2025
dmmulroy
force-pushed
the
dmmulroy/fix-quick-edit
branch
from
695da77 to
75ecbc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes syntax highlighting in the Quick Editor light theme. Variables were appearing as gray instead of being colored.
Why only some users saw this bug: VS Code uses two highlighting systems - semantic highlighting (from TypeScript/JS language service) and TextMate tokenization (regex-based fallback). Semantic highlighting layers on top of TextMate and masks theme bugs when active. Users hit the broken TextMate fallback when:
Root cause: Light theme's Variables rule had
variable.otherinstead ofvariable. Per TextMate scope matching,variable.otheronly matchesvariable.other.*tokens, not plainvariabletokens. The dark theme correctly usesvariable.Changes:
variablescope to light theme Variables rulevariable.other(covered byvariable)variable.other.objectentries from both themes