[6.x] External URLs in the nav should render as <a> elements#14174
Merged
jasonvarga merged 3 commits into6.xfrom Mar 9, 2026
Merged
[6.x] External URLs in the nav should render as <a> elements#14174jasonvarga merged 3 commits into6.xfrom
<a> elements#14174jasonvarga merged 3 commits into6.xfrom
Conversation
Member
|
Since nav item urls arriving at the Nav vue component are all absolute, they all start with http/https, so they were all being considered external. Nothing was being rendered as an Inertia Link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that external URLs in the nav are rendered as
<a>elements, as opposed to Inertia<Link>components which may triggers CORS errors.