SpeedScopeExporter#842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 17.4% 17.58% +0.18%
==========================================
Files 222 224 +2
Lines 137834 138440 +606
Branches 12203 12243 +40
==========================================
+ Hits 23984 24345 +361
- Misses 112912 113152 +240
- Partials 938 943 +5
Continue to review full report at Codecov.
|
| public static class SpeedScopeExporter | ||
| { | ||
| /// <summary> | ||
| /// exports provided StackSource to a https://www.speedscope.app/ format |
There was a problem hiding this comment.
Can you also include the links to the documentation on the format that you put in an e-mail to me.
|
|
||
| namespace Microsoft.Diagnostics.Tracing.Stacks | ||
| { | ||
| public static class SpeedScopeExporter |
There was a problem hiding this comment.
Call it SpeedScopeStackSourceWriter to be consistent with XmlStackSourceWriter.
|
Go ahead and make a user command 'NetPerfToSpeedScope' (like 'NewPerfToJson in https://github.com/Microsoft/perfview/pull/822/files) so that we have something immediately that we can use for demos. I am OK with merging this with minimal testing (what you have is enough), as long as there are not known issues. Do you know of any issues? |
|
Let me know when you are ready. Things that are left are
For 2. you can just paste this into the UserCommands.cs file |
|
@vancem I have fixed all issues, it's ready for final review and merge (if it passes the review ;) ) |
|
LGTM Thanks Adam for doing this! This gives us a viewing 'story' on Linux and Mac for netperf files. |
@vancem this is the initial version, WIP
Sample exported file: https://gist.github.com/adamsitnik/db8f40f4e84fd9c2975b7ce7b8b468c0 (you need to click the raw button and save it as file and then upload to https://www.speedscope.app/)