-
Notifications
You must be signed in to change notification settings - Fork 237
Implement Chat: Clients able to send messages in a room #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
unicode text is working. |
|
The current problem in chat is, there is To tackle this problem we can |
|
You have to rebase your changes away from your other PR though. |
|
rebased away the changes in the other PR |
|
another way we could stop large messages from displaying on the player is after a limit we could display only a certain part of the message, followed by "..." , rest of it could be read within the client or on the console |
|
How are you going to determine what's big message? (i.e. difference between fullHD and laptop screen) |
|
a full hd screen can have more characters , but displaying a part of the message would only serve as a kind of notification, so displaying less characters on a bigger screen is not a big deal IMO. |
|
Hey @abhsag24 , would be glad to help you on this! |
|
@remimarenco would love to have help, as you can see i had already listed out the things that needed to be done further. What do you suggest? |
|
@abhsag24 We should take some time to discuss about your vision on your branch, and see how we can work together on this. I found the letsgaze system pretty handy to handle the chat |
|
I'm really looking forward to this functionality. I think having the conversation more closely tied with the on-screen action is essential for making it a more social experience. Using Skype works and all, but I agree with @remimarenco that it's not always ideal to be on voice or to have to rely on another program to send text which requires keeping another window / screen active. |
|
@perfectcolors and @remimarenco i think i've added the basic chat functionality in this PR already, you can go ahead and use it, but you'll have to chat from within the terminal and there are some concerns that i had stated earlier, i don't know much about the GUI and don't have the time right now to add that functionality :( , but it should be pretty usable :) |
|
Merged into https://github.com/Syncplay/syncplay/tree/chat |
|
awesome! so should i close this PR? |
|
Closing this as PR has been accepted onto the chat branch. |
refinements are still left such as, username is not displayed, the basic framework is done.