Skip to content

Conversation

@abh3po
Copy link
Contributor

@abh3po abh3po commented Dec 26, 2015

refinements are still left such as, username is not displayed, the basic framework is done.

@abh3po
Copy link
Contributor Author

abh3po commented Dec 26, 2015

unicode text is working.

@abh3po
Copy link
Contributor Author

abh3po commented Dec 31, 2015

The current problem in chat is, there is
1.No UI to send Chat messages, right now.
2.if user types large messages, they are displayed on the screen, which disturbs the viewing experience

To tackle this problem we can
a. Stop displaying messages in the player altogether
or
b. Limit the length of message so that they are unobtrusive on the player (preferred)
or
c. Give the power to the client to stop displaying message on the screen in real time.

@Uriziel
Copy link
Contributor

Uriziel commented Dec 31, 2015

You have to rebase your changes away from your other PR though.

@abh3po
Copy link
Contributor Author

abh3po commented Jan 1, 2016

rebased away the changes in the other PR

@abh3po
Copy link
Contributor Author

abh3po commented Jan 12, 2016

another way we could stop large messages from displaying on the player is after a limit we could display only a certain part of the message, followed by "..." , rest of it could be read within the client or on the console

@Uriziel
Copy link
Contributor

Uriziel commented Jan 12, 2016

How are you going to determine what's big message? (i.e. difference between fullHD and laptop screen)

@abh3po
Copy link
Contributor Author

abh3po commented Jan 13, 2016

a full hd screen can have more characters , but displaying a part of the message would only serve as a kind of notification, so displaying less characters on a bigger screen is not a big deal IMO.

@remimarenco
Copy link
Contributor

Hey @abhsag24 , would be glad to help you on this!

@abh3po
Copy link
Contributor Author

abh3po commented Jan 26, 2016

@remimarenco would love to have help, as you can see i had already listed out the things that needed to be done further. What do you suggest?

@remimarenco
Copy link
Contributor

@abhsag24 We should take some time to discuss about your vision on your branch, and see how we can work together on this.
Personally, I just want to be able to chat with my loved one while we are watching the movie. Annoying to have to use a third party system or to speak.

I found the letsgaze system pretty handy to handle the chat

@ghost
Copy link

ghost commented Mar 10, 2016

I'm really looking forward to this functionality. I think having the conversation more closely tied with the on-screen action is essential for making it a more social experience.

Using Skype works and all, but I agree with @remimarenco that it's not always ideal to be on voice or to have to rely on another program to send text which requires keeping another window / screen active.

@abh3po
Copy link
Contributor Author

abh3po commented Mar 10, 2016

@perfectcolors and @remimarenco i think i've added the basic chat functionality in this PR already, you can go ahead and use it, but you'll have to chat from within the terminal and there are some concerns that i had stated earlier, i don't know much about the GUI and don't have the time right now to add that functionality :( , but it should be pretty usable :)

@Et0h
Copy link
Contributor

Et0h commented Jul 3, 2016

@abh3po
Copy link
Contributor Author

abh3po commented Jul 4, 2016

awesome! so should i close this PR?

@Et0h Et0h mentioned this pull request Jul 7, 2016
@Et0h
Copy link
Contributor

Et0h commented Jul 7, 2016

Closing this as PR has been accepted onto the chat branch.

@Et0h Et0h closed this Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants