fix: folders with names of unlinked entries are linked#1027
Conversation
CyanVoxel
left a comment
There was a problem hiding this comment.
It looks like everything that's here fixes the specific areas they target, but there's still a few circumstances left that should be addressed before #989 should be considered closed:
- The relink process still does not check if a file is a folder when relinking
- Various methods in
ThumbRendererandPreviewThumbsuch as_image_thumb()will crash the program or throw a traceback if trying to render a thumbnail for a file that's been swapped with a folder of the same name, most notably_image_thumb()in my testing
I thought there may have been some stuff I missed. 🤔 I'll work on those changes as soon as I can. 👍 |
de574cb to
ef16ffa
Compare
|
Sorry for the force push, had to fix conflicts. Anyways, all requested changes should be finished. Let me know if there is anything else I should change 😄 |
CyanVoxel
left a comment
There was a problem hiding this comment.
Everything seems to be fixed up here, thank you for your work on this!
…1027) * fix: render folder entries as unlinked * fix: hide file size for linked folders * fix: linked folders can be revealed in explorer * fix: linked folders can be opened * fix: linked folders can be deleted * fix: skip rendering thumbnails in `ThumbRenderer._render` * fix: skip getting image metadata for folders * fix: conflicts * style: ruff
Summary
Fixes #989
When a unlinked entry has a folder with the same name:
Let me know if there is any changes you would like me to make :)
Tasks Completed