Skip to content

feat: remove carmin API#1482

Merged
prioux merged 5 commits into
aces:masterfrom
Freedisch:remove_carmin_api
May 20, 2025
Merged

feat: remove carmin API#1482
prioux merged 5 commits into
aces:masterfrom
Freedisch:remove_carmin_api

Conversation

@Freedisch

Copy link
Copy Markdown
Contributor

fix issue #1403

  • Deleted carmin_path_data_provider.rb
  • Deleted carmin_controller.rb
  • Deleted carmin_path_data_provider.rb
  • Deleted carmin_error.rb
  • remove carmin route and seed_test

Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
@prioux

prioux commented Mar 11, 2025

Copy link
Copy Markdown
Member

Oh wow. Thanks, I had forgotten CARMIN touched on so many parts of the codebase (even though I'm the person who wrote it all originally!).

I'll have to pull the changes and check things locally in order to do a proper review.

@Freedisch

Copy link
Copy Markdown
Contributor Author

Oh wow. Thanks, I had forgotten CARMIN touched on so many parts of the codebase (even though I'm the person who wrote it all originally!).

I'll have to pull the changes and check things locally in order to do a proper review.

Noted, I'm still also reviewing on my side to see if I haven't missed some parts

@prioux

prioux commented Mar 12, 2025

Copy link
Copy Markdown
Member

I checked it out and ran the server locally, everything works and I can't think of any other places where CARMIN code is located. I'll merge when I have approval from my boss.

@prioux

prioux commented Mar 13, 2025

Copy link
Copy Markdown
Member

Just FYI because of administrative delays, this PR might be merged only at the end of the months (in two weeks).

@Freedisch

Copy link
Copy Markdown
Contributor Author

Just FYI because of administrative delays, this PR might be merged only at the end of the months (in two weeks).

Noted 🫡

@prioux

prioux commented Mar 25, 2025

Copy link
Copy Markdown
Member

Hello @Freedisch , as I said your PR is perfectly fine as far as I know and I would like to merge it right away, but it was decided to leave CARMIN in CBRAIN for another six months. So we will just leave the PR here, ready to be merged, for six more months. Sorry about that!

@prioux prioux added External Hold Refactoring API API issues or Swagger description Boutiques Boutiques integration labels Mar 25, 2025
@prioux prioux linked an issue Mar 25, 2025 that may be closed by this pull request
@prioux prioux self-requested a review March 25, 2025 13:48
@prioux

prioux commented May 20, 2025

Copy link
Copy Markdown
Member

Hello @Freedisch, good news, this has been approved for merging.

@prioux prioux merged commit f53ff6d into aces:master May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API API issues or Swagger description Boutiques Boutiques integration External Hold Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all CARMIN API stuff

2 participants