feat: remove carmin API#1482
Conversation
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
|
Oh wow. Thanks, I had forgotten CARMIN touched on so many parts of the codebase (even though I'm the person who wrote it all originally!). I'll have to pull the changes and check things locally in order to do a proper review. |
Noted, I'm still also reviewing on my side to see if I haven't missed some parts |
|
I checked it out and ran the server locally, everything works and I can't think of any other places where CARMIN code is located. I'll merge when I have approval from my boss. |
|
Just FYI because of administrative delays, this PR might be merged only at the end of the months (in two weeks). |
Noted 🫡 |
|
Hello @Freedisch , as I said your PR is perfectly fine as far as I know and I would like to merge it right away, but it was decided to leave CARMIN in CBRAIN for another six months. So we will just leave the PR here, ready to be merged, for six more months. Sorry about that! |
|
Hello @Freedisch, good news, this has been approved for merging. |
fix issue #1403
carmin_path_data_provider.rbcarmin_controller.rbcarmin_path_data_provider.rbcarmin_error.rb