test: update CommitHash length assertion for SHA-256 support#4348
Closed
yaananth wants to merge 1 commit into
Closed
test: update CommitHash length assertion for SHA-256 support#4348yaananth wants to merge 1 commit into
yaananth wants to merge 1 commit into
Conversation
Allow CommitHash to be either 40 chars (SHA-1) or 64 chars (SHA-256). Add hex format validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ConstantGenerationL0 test to accommodate repositories using SHA-256 object IDs by accepting both SHA-1 and SHA-256 commit hash lengths, while also validating that the value is hex.
Changes:
- Update the commit hash length assertion to allow 40 (SHA-1) or 64 (SHA-256) characters.
- Add a regex assertion to ensure the commit hash is a hex string.
Show a summary per file
| File | Description |
|---|---|
src/Test/L0/ConstantGenerationL0.cs |
Adjusts CommitHash assertions to support SHA-256 and validates hex format. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ConstantGenerationL0 test to accept both 40-char (SHA-1) and 64-char (SHA-256) commit hashes. Add hex format validation.
Automated by project-board-agents-plugin via /project-board-agents:lead
Board: https://github.com/orgs/github/projects/24272/views/1
Item: [P2] Update runner build constant SHA length assertion