Skip to content

Change log message when computing integrity hash #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heifner merged 2 commits into from
Mar 25, 2025
Merged

Change log message when computing integrity hash #1271

heifner merged 2 commits into from
Mar 25, 2025

Conversation

@heifner
Copy link
Contributor

@heifner heifner commented Mar 24, 2025

Update the percentage log output of snapshot creation to report type of snapshot being created. Uses integrity hash for the integrity hash creation on startup and shutdown.

info  2025-03-24T18:04:19.004 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 0% complete
info  2025-03-24T18:05:04.005 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 7% complete
info  2025-03-24T18:05:20.612 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 12% complete
info  2025-03-24T18:06:58.004 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 26% complete
info  2025-03-24T18:07:15.242 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 42% complete
info  2025-03-24T18:09:07.009 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 68% complete
info  2025-03-24T18:10:07.050 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 95% complete
info  2025-03-24T18:10:32.049 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 97% complete
info  2025-03-24T18:10:34.735 nodeos    controller.cpp:2039           init                 ] chain database started with hash: db466873134910fa7a3184746efbdd2eb3fa62f7c0fd01db341f6dd4e5ee029f
...
info  2025-03-24T18:10:39.008 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 5% complete
info  2025-03-24T18:11:55.219 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 13% complete
info  2025-03-24T18:12:21.048 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 41% complete
info  2025-03-24T18:13:28.651 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 68% complete
info  2025-03-24T18:13:39.080 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 95% complete
info  2025-03-24T18:13:59.186 nodeos    snapshot.hpp:457              progress             ] integrity hash creation 96% complete
info  2025-03-24T18:14:15.829 nodeos    controller.cpp:2092           ~controller_impl     ] chain database stopped with hash: db466873134910fa7a3184746efbdd2eb3fa62f7c0fd01db341f6dd4e5ee029f

Resolves #1147

@heifner
GH-1147 Change percentage log output of snapshot creation to report t…
e186a90 
…ype of snapshot being created. Uses integrity hash for the integrity hash creation on startup and shutdown.
@heifner heifner added the OCI Work exclusive to OCI team label Mar 24, 2025
@heifner heifner requested review from greg7mdp and spoonincode March 24, 2025 18:31
@greg7mdp
Copy link
Contributor

greg7mdp commented Mar 24, 2025

I think it would be a little bit clearer if it said:

snapshot creation (for integrity hash computation) x% complete

but probably OK as it is.

spoonincode
spoonincode reviewed Mar 24, 2025
View reviewed changes
libraries/chain/include/eosio/chain/snapshot.hpp Outdated
}
size_t count = 0;
const size_t total = 0;
const char* name;
Copy link
Contributor

@spoonincode spoonincode Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider = nullptring this

@heifner heifner merged commit 0b5a684 into main Mar 25, 2025
36 checks passed
@heifner heifner deleted the GH-1147-integrity-hash-log branch March 25, 2025 14:00
@ericpassmore
Copy link
Contributor

ericpassmore commented Apr 3, 2025

Note:start
category: Logging
component: Internal
summary: Change log message when computing integrity hash.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@spoonincode spoonincode spoonincode approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OCI Work exclusive to OCI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update log message when computing integrity hash

5 participants

@heifner @greg7mdp @ericpassmore @spoonincode @linh2931