Cherry pick Remove unneeded rc feature of serde to active_release#1016
Merged
Conversation
Fixes #989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
Codecov Report
@@ Coverage Diff @@
## active_release #1016 +/- ##
===============================================
Coverage 82.37% 82.38%
===============================================
Files 168 168
Lines 49133 49133
===============================================
+ Hits 40474 40476 +2
+ Misses 8659 8657 -2
Continue to review full report at Codecov.
|
Contributor
Author
|
SIMD checks are failing due to some error in the nightly rust compiler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of 771b248
rcfeature of serde #990: Remove unneededrcfeature of serde