This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[WIP] Windows dev environment configuration, update install instructions from source in the docs.#17206
Closed
larroy wants to merge 25 commits intoapache:masterfrom
Closed
[WIP] Windows dev environment configuration, update install instructions from source in the docs.#17206larroy wants to merge 25 commits intoapache:masterfrom
larroy wants to merge 25 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@mxnet-label-bot add [pr-awaiting-review] |
marcoabreu
reviewed
Jan 3, 2020
yajiedesign
reviewed
Jan 4, 2020
Contributor
Author
|
😴 |
e1d0c15 to
fa4641d
Compare
marcoabreu
approved these changes
Jan 14, 2020
Contributor
marcoabreu
left a comment
There was a problem hiding this comment.
Lgtm besides nits.
I'd prefer if someone else could review the docs changes
| @@ -0,0 +1,4 @@ | |||
| psutil | |||
| boto3 | |||
| python-jenkins | |||
Contributor
Author
There was a problem hiding this comment.
I think you added it, is it in the slave scripts?
Contributor
There was a problem hiding this comment.
Well yeah it's used as part of the Autoconnect script. But since you are recommending this for users to install, it seems a bit out of place. We should handle infrastructure and MXNet related things separately if possible.
Contributor
Author
There was a problem hiding this comment.
we can remove it in the future, it doesn't hurt there now, and I don't want additional scripts as of now. I don't think this is a big concern, even though you are right.
f862851 to
4642f91
Compare
0a3e40e to
9c9052b
Compare
…missing kernel32.lib
Work around compiler running out of heap.
Co-Authored-By: Aaron Markham <markhama@amazon.com>
…ot picked up (mingw or gcc is picked up instead)
9d9e0ab to
12f3c9e
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update windows build from source documentation with automated scripts.
As part of fixing the windows CI AMI, the scripts to setup the build environment are referenced from the documentation for ease of use.
With this PR seting up the environment in windows consists of executing just a powershell script
Together with
ci/build_windows.pythis makes 2 commands to build MXNet in a clean windows install.Before the process to setup the required environment required tons of manual and error prone install and steps.
Chance Bair is also co-author of the installation script.
Verified that the updated instructions lead to a working MXNet build:
@aaronmarkham @leezu @Chancebair