Fix 3 post-QA issues on api command

[jeremy]

Summary

Fixes 3 issues found during QA of the api command on Windows (v0.4.1):

• Leading slash breaks on Windows: parsePath now strips a leading slash instead of ensuring one. The SDK's accountPath and buildURL both prepend a slash, so keeping it in parsePath double-slashes — and on Windows, MSYS/Git Bash converts /path to C:\...\path before Go sees it. All 5 command examples updated to use bare paths (projects.json not /projects.json).

• "ID required" instead of "path required": basecamp api get (no args) hit the global transformArgError which rewrites Cobra's generic missing-arg message to "ID required". Custom apiPathArgs validator emits "path required" directly.

• --todolist leaks into agent help: emitAgentHelp dumped all inherited flags unfiltered. Extracted curatedInheritedFlags from filterInheritedFlags so both text and agent help share the same filtering: salientRootFlags allowlist, root pointer-identity check, and --project suppression for <id|url> commands.

Card: https://3.basecamp.com/2914079/buckets/46292715/card_tables/cards/9660578055

Test plan

• bin/ci passes (lint, unit tests, e2e, surface snapshot, skill drift)
• bin/basecamp api get --help — examples show projects.json not /projects.json
• bin/basecamp api get — error says "path required"
• bin/basecamp api --agent --help | jq .inherited_flags — no todolist
• bin/basecamp subscriptions show --agent --help | jq .inherited_flags — no project
• Windows: basecamp api get projects.json works without MSYS path mangling

[github-actions]

⚠️ Potential breaking changes detected:

• Change in the Example field for the 'api' command and its subcommands (get, post, put, delete) from having paths start with '/' to omitting the leading slash, which may break existing scripts that use the CLI with expected input format.
• Modification of argument validation by replacing 'Args: cobra.ExactArgs(1)' with the new custom 'apiPathArgs' validation function, which changes error messages when arguments do not match expected patterns. Scripts depending on specific error outputs could break.

Review carefully before merging. Consider a major version bump.

[cubic-dev-ai]

2 issues found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/commands/api.go">

<violation number="1" location="internal/commands/api.go:205">
P2: The URL branch still returns a path with a leading slash (e.g. `/projects.json`), contradicting the new comment and the fix applied to the relative-path branch. If the SDK prepends its own slash, full-URL inputs will still double-slash.</violation>

<violation number="2" location="internal/commands/api.go:215">
P2: `apiBreadcrumbs` patterns all expect a leading `/` (e.g. `HasSuffix(path, "/projects.json")`, regex `/buckets/(\d+)`). Since `parsePath` no longer prepends one for relative paths, breadcrumbs will never match for bare-path inputs like `projects.json` or `buckets/123/todos/456.json`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Copilot]

Pull request overview

Addresses QA-found issues in the basecamp api command and agent help output, with a focus on Windows path handling and consistent help flag curation.

Changes:

• Updates api command examples and path parsing/arg validation to improve Windows compatibility and error messaging.
• Introduces shared inherited-flag curation for both text help and --agent --help JSON output.
• Adds unit tests for parsePath, apiPathArgs, and agent-help inherited-flag filtering behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/commands/api.go	Updates examples, switches to custom arg validator, and changes parsePath behavior.
internal/commands/api_test.go	Adds unit tests for parsePath and apiPathArgs.
internal/cli/root.go	Uses curated inherited flags when emitting agent JSON help.
internal/cli/help.go	Extracts shared curatedInheritedFlags used by both text and agent help.
internal/cli/help_test.go	Adds tests asserting agent help inherited-flag filtering/suppression.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a0e936faf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

basecamp-cli/internal/cli/help.go

Lines 403 to 405 in 682ea48

	rootFlag := root.PersistentFlags().Lookup(f.Name)
	if rootFlag == nil || rootFlag != f {
	return // parent-scoped — already promoted to FLAGS

Preserve parent inherited flags in agent help output

This root-only filter drops every parent-scoped persistent flag from curatedInheritedFlags, and emitAgentHelp now uses this filtered set directly, so --agent --help can omit valid options entirely because agent help has no equivalent of text-help’s parent-flag promotion into flags. That breaks machine discovery for leaf commands that rely on parent flags (for example, messages list can use parent --message-board from internal/commands/messages.go:37), which now appears in neither flags nor inherited_flags. Fresh evidence: this commit changed emitAgentHelp to call curatedInheritedFlags(cmd) at internal/cli/root.go:731, so the drop now affects agent JSON output directly.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

Fixes QA-reported Windows and help-output issues for the basecamp api command by normalizing path handling, improving missing-arg validation, and aligning agent JSON help flag curation with text help.

Changes:

• Updated api command examples and parsePath behavior to avoid leading-slash MSYS/Git Bash path mangling on Windows.
• Added a custom positional-arg validator (apiPathArgs) so missing args report “path required” (instead of being rewritten to “ID required”).
• Refactored inherited-flag filtering into curatedInheritedFlags and applied it to agent JSON help; also promotes parent-scoped flags into agent help flags to match text help behavior, with tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/commands/api.go	Normalizes API path handling, updates examples, adds apiPathArgs, and fixes breadcrumbs matching for bare paths.
internal/commands/api_test.go	Adds unit tests for parsePath and apiPathArgs behavior.
internal/cli/help.go	Extracts inherited-flag curation into curatedInheritedFlags for shared use between text and agent help.
internal/cli/root.go	Updates agent JSON help to promote parent-scoped flags and use curated inherited flags.
internal/cli/help_test.go	Adds tests ensuring agent help filters inherited flags and promotes parent-scoped flags.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.