Fix incorrect Javadoc in EllipticCurveKeyPairGenerator example#2269
Closed
Joowon-Seo wants to merge 1 commit into
Closed
Fix incorrect Javadoc in EllipticCurveKeyPairGenerator example#2269Joowon-Seo wants to merge 1 commit into
Joowon-Seo wants to merge 1 commit into
Conversation
The example generates an Ed25519/X25519 OpenPGP key ring, but the Javadoc incorrectly states that it generates an RSA key ring. This commit updates the documentation and usage text accordingly.
Joowon-Seo
force-pushed
the
docs/fix-elliptic-curve-keypair-generator-javadoc
branch
from
1483998 to
686a11b
Compare
Collaborator
|
Merged, thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Javadoc for EllipticCurveKeyPairGenerator incorrectly states that it generates an RSA key ring.
However the implementation generates an OpenPGP key ring using:
This PR updates the Javadoc and usage text to correctly describe the
generated key types.