Skip to content

ci: bump github actions#2739

Closed
Fdawgs wants to merge 1 commit into
brianc:masterfrom
Fdawgs:patch-1
Closed

ci: bump github actions#2739
Fdawgs wants to merge 1 commit into
brianc:masterfrom
Fdawgs:patch-1

Conversation

@Fdawgs
Copy link
Copy Markdown
Contributor

@Fdawgs Fdawgs commented May 3, 2022

Bumps GitHub Actions to their latest major versions. Main change is they're now using Node 16 instead of 12, which was EOL at end of April.

  • Changelog for actions/checkout can be found here
  • Releases for actions/setup-node can be found here

@brianc
Copy link
Copy Markdown
Owner

brianc commented May 3, 2022

Thanks for doing this! Definitely want to upgrade but....hmmmm any idea why all the CI checks failed?

@charmander
Copy link
Copy Markdown
Collaborator

@brianc One of stream-tester’s transitive dependencies. It’s been failing the same way on current master for a while.

@Fdawgs
Copy link
Copy Markdown
Contributor Author

Fdawgs commented May 4, 2022

One of stream-tester’s transitive dependencies. It’s been failing the same way on current master for a while.

Thanks @charmander, had looked at the errors thrown and couldn't tell why it was failing.

@brianc
Copy link
Copy Markdown
Owner

brianc commented May 4, 2022

One of stream-tester’s transitive dependencies. It’s been failing the same way on current master for a while.

barf. going to just kill this dep & remove stream tester. hasn't really provided much value anyway. I'll get that patched up, and then unfortunatley ask PR contributors to rebase on master once I remove this broken dep. Wish github made that busy-work easier to do behind a button like "bring PR up to date with merge target" or something.

@brianc brianc mentioned this pull request May 10, 2022
@brianc
Copy link
Copy Markdown
Owner

brianc commented May 11, 2022

@Fdawgs thanks for doing this! I went ahead and bumped it on #2743 because I was trying to fix CI from being broken so this isn't needed anymore, but thanks for contributing...your bumping this forward helped me start pulling on the thread!

@brianc brianc closed this May 11, 2022
@Fdawgs
Copy link
Copy Markdown
Contributor Author

Fdawgs commented May 11, 2022

Great, thanks @brianc!

@Fdawgs Fdawgs deleted the patch-1 branch May 11, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants