Skip to content

DIP Quorum rotation#4512

Closed
ogabrielides wants to merge 111 commits intodashpay:developfrom
ogabrielides:quorum_rotation_dip_dev
Closed

DIP Quorum rotation#4512
ogabrielides wants to merge 111 commits intodashpay:developfrom
ogabrielides:quorum_rotation_dip_dev

Conversation

@ogabrielides
Copy link

@ogabrielides ogabrielides commented Oct 12, 2021 •
edited
Loading

Known gaps still needed to be filled (implementation needed or investigation):

  • Error handling when InitQuorum fails to create the new quorum quarter
  • If a DKG failed at cycle at height h due to a failure, the quarters that were calculated this cycle are still taken into account for next cycles’s calculations
  • Implement SkipMode 2 when building a new CQuorumSnapshot
  • llmqType + dkgBlockHash is not enough to identify a quorum. quorumIndex should be included as well (as @UdjinM6 suggested)
  • Choosing the active llmq for signing
  • CQuorumSnapshot.activeQuorum field type should be changed to a CFixedBitset for space optimization.
  • Investigate if condensation of the quorum commitment message into a smaller batched quorum commitment message needs to be done
  • Add version 2 of CFinalCommitment when using quorumIndex in the quorumHash
  • Number of active quorums (that do rotation) needs to be a power of two
  • Number of quourm members (that do rotation) needs to be divisible by four
  • Merge DIP24 and Governance Fee as one deployment

@github-actions
Copy link

github-actions bot commented Oct 12, 2021

This pull request has conflicts, please rebase.

@PastaPastaPasta PastaPastaPasta modified the milestones: 17, 18 Oct 15, 2021
thephez
thephez reviewed Oct 18, 2021
View reviewed changes
PastaPastaPasta
PastaPastaPasta reviewed Oct 22, 2021
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@ogabrielides ogabrielides marked this pull request as draft October 29, 2021 11:53
@ogabrielides ogabrielides marked this pull request as ready for review November 1, 2021 15:25
@github-actions

This comment has been minimized.

Sign in to view
@ogabrielides ogabrielides marked this pull request as draft November 1, 2021 16:01
ogabrielides and others added 23 commits April 6, 2022 11:23
@ogabrielides
Various cleanups
173cf02
@UdjinM6 @ogabrielides
use unordered_lru_cache for quorumSnapshotCache
e14b953
@UdjinM6 @ogabrielides
trivial refactor ComputeQuorumMembersByQuarterRotation
578a313
@ogabrielides
Reduced CFinalCommitment::quorumIndex from 32 to 16 bits
e520357
@ogabrielides
Keep verified LLMQ relay connections
967d7d0
@ogabrielides
Experimental Relay connection fix
1b1807f
@ogabrielides
Fix for EnsureQuorumConnections rotation
8595527
@ogabrielides
Using only valid Mns for checking
2b4d369
@ogabrielides
Override of nPowTargetSpacing (devnet only)
3cc69b8
@ogabrielides
Show penalty score in masternode rpc
34ccdcf
@PastaPastaPasta @ogabrielides
fixup! not relevant whitespace diff
e0abf1d
@PastaPastaPasta @ogabrielides
fixup! use int() instead of static_cast
33786d2
@PastaPastaPasta @ogabrielides
fixup! not-relevant whitespace
fc02e29
@PastaPastaPasta @ogabrielides
fixup! TODOs
a4c4a00
@PastaPastaPasta @ogabrielides
fixup! use more verbose name
6190ad9
@PastaPastaPasta @ogabrielides
fixup! default quorumIndex to 0
d5a1513
@PastaPastaPasta @ogabrielides
fixup! default quorumIndex to 0
e9b1df1
@PastaPastaPasta @ogabrielides
fixup! formatting
5eb4139
@PastaPastaPasta @ogabrielides
fixup! remove unneeded includes
edaee1f
@PastaPastaPasta @ogabrielides
fixup! use Mutex instead of CCriticalSection
2b2eeba
@PastaPastaPasta @ogabrielides
fix: linter fixes
c0b6ea0
@ogabrielides
Applied corrections
4087309
@ogabrielides
Applied corrections
da5a28c
@ogabrielides ogabrielides marked this pull request as draft April 7, 2022 11:28
@ogabrielides
Copy link
Author

ogabrielides commented Apr 7, 2022

@UdjinM6 @PastaPastaPasta Converted this one as a draft, since #4752 will be merged.

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Apr 15, 2022

Closing as superseded by #4752

@ogabrielides ogabrielides deleted the quorum_rotation_dip_dev branch April 18, 2022 10:07
@knst knst mentioned this pull request Feb 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta left review comments

@thephez thephez thephez left review comments

@UdjinM6 UdjinM6 Awaiting requested review from UdjinM6

+1 more reviewer

@HashEngineering HashEngineering HashEngineering left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ogabrielides ogabrielides

Labels

P2P Some notable changes on p2p level RPC Some notable changes to RPC params/behaviour/descriptions

Projects

Core Dev Backlog
Status: Done

Milestone

18

Development

Successfully merging this pull request may close these issues.

6 participants

@ogabrielides @UdjinM6 @PastaPastaPasta @HashEngineering @thephez @kwvg