feat(to): add table option#3572
Merged
Merged
Conversation
Closes #3568. Allows users to specify a custom table name when converting CSV to postgres or sqlite, overriding the default name derived from the input filename (which defaults to "stdin" when reading from stdin). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Check `arg_input.len() != 1` instead of `> 1` so empty input is rejected rather than silently ignored - Cap table name length at 63 characters (PostgreSQL identifier limit) - Preserve original file extension when copying to temp dir instead of always using .csv, so delimiter sniffing by extension still works for .tsv/.ssv files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…action - Change comment from "63 bytes" to "63 characters" to match the error message (functionally equivalent since validation restricts to ASCII) - Simplify file extension extraction using map_or instead of unwrap_or_default + to_string_lossy + if-else block Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3568