This repository was archived by the owner on Jun 6, 2024. It is now read-only.
[Hackathon] Custom policy to check if configuration file consist the name of the deployment#314
Closed
kaiwalyakoparkar wants to merge 2 commits intodatreeio:mainfrom
Closed
[Hackathon] Custom policy to check if configuration file consist the name of the deployment#314kaiwalyakoparkar wants to merge 2 commits intodatreeio:mainfrom
kaiwalyakoparkar wants to merge 2 commits intodatreeio:mainfrom
Conversation
…name of the deployment
Member
|
@kaiwalyakoparkar it looks like your custom rule doesn't match the description in your policy README. |
Author
|
@eyarz Sorry for that. I missed updating it as I was experimenting with lot of stuff. I will change it now. |
Member
|
Thank you for participating in the Hackaton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While starting the configuration it's essential to make sure that there is
namespecified for the deployment.Why
Not having this might not raise errors by the native development kits (kubectl etc) but naming the deployment configurations while working with several clusters in a team is essential and cosidered a good practice.