fix: correct deserialization order of sequence/routine/membership in …#2694
Merged
Conversation
…auth The serialize() function wrote fields in this order: tablePrivileges → sequencePrivileges → routinePrivileges → roleMembership But deserializeV1() read them in a different order: tablePrivileges → roleMembership → routinePrivileges → sequencePrivileges This mismatch went unnoticed because all three sections (sequencePrivileges, routinePrivileges, roleMembership) have the same zero-value byte representation (count=0) when no privileges exist. Once GRANT ALL PRIVILEGES ON ALL ROUTINES or GRANT ALL PRIVILEGES ON ALL FUNCTIONS is executed, routinePrivileges becomes non-empty, the reader offset shifts, and doltgres panics with an index out of range error on the next startup when attempting to read the persisted auth file. Fix deserializeV1() to match the order used by serialize(). Fixes dolthub#2693
Author
|
@jennifersp You have implemented this part of code, please check. |
Contributor
|
Thank you for fixing this error! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…auth
The serialize() function wrote fields in this order:
tablePrivileges → sequencePrivileges → routinePrivileges → roleMembership
But deserializeV1() read them in a different order:
tablePrivileges → roleMembership → routinePrivileges → sequencePrivileges
This mismatch went unnoticed because all three sections (sequencePrivileges, routinePrivileges, roleMembership) have the same zero-value byte representation (count=0) when no privileges exist. Once GRANT ALL PRIVILEGES ON ALL ROUTINES or GRANT ALL PRIVILEGES ON ALL FUNCTIONS is executed, routinePrivileges becomes non-empty, the reader offset shifts, and doltgres panics with an index out of range error on the next startup when attempting to read the persisted auth file.
Fix deserializeV1() to match the order used by serialize().
Fixes #2693