Skip to content

chore: use golang 1.N.P version syntax#3215

Merged
zirain merged 2 commits into
envoyproxy:mainfrom
guydc:go-patch
Apr 18, 2024
Merged

chore: use golang 1.N.P version syntax#3215
zirain merged 2 commits into
envoyproxy:mainfrom
guydc:go-patch

Conversation

@guydc

@guydc guydc commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
CodeQL is reporting an invalid golang toolchain version syntax:

As of Go 1.21, toolchain versions must use the 1.N.P syntax.
1.22 in tools/src/setup-envtest/go.mod does not match this syntax and there is no additional toolchain directive, which may cause some go commands to fail.
CodeQL also found 9 other warnings like this. See the workflow log for details.

Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from a team as a code owner April 17, 2024 21:59
@guydc

guydc commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@guydc

guydc commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@shawnh2 shawnh2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, maybe that is the reason why I always receive toolchains not found for go1.22 error on my local dev env.

@zirain zirain merged commit 64b115f into envoyproxy:main Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants