Skip to content

Log youtube-dl version and warn if known to have issues.#919

Merged
elelay merged 1 commit into
gpodder:masterfrom
auouymous:ytdl-version-check
Dec 14, 2020
Merged

Log youtube-dl version and warn if known to have issues.#919
elelay merged 1 commit into
gpodder:masterfrom
auouymous:ytdl-version-check

Conversation

@auouymous

Copy link
Copy Markdown
Member

The logging might help with debugging youtube-dl issues, and the warning can be used to flag known broken versions.

@computerfreak105

computerfreak105 commented Dec 9, 2020 via email

Copy link
Copy Markdown

@auouymous

Copy link
Copy Markdown
Member Author

The warning would only trigger for issues known at the time of a gpodder release. When 3.10.17 was released, it was known that youtube-dl versions before 2020.11.12 had issues. Even though 3.10.17 fixed part of the issue, an updated youtube-dl would be required to properly work.

I assume the windows version includes the version of youtube-dl available at time of release, and this warning would never be shown for someone using a bundled version. If this is true, you can update the bundled youtube-dl by grabbing the newest git version of gpodder at https://ci.appveyor.com/project/elelay/gpodder/build/artifacts.

@elelay elelay merged commit 46cf814 into gpodder:master Dec 14, 2020
@elelay

elelay commented Dec 14, 2020

Copy link
Copy Markdown
Member

Merged, thanks

@auouymous auouymous deleted the ytdl-version-check branch December 14, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants