fix: allow specifying id attribute for blockquotes and tables#247
Merged
razonyang merged 3 commits intohbstack:mainfrom Sep 10, 2024
TetraTheta:attr
Merged
fix: allow specifying id attribute for blockquotes and tables#247razonyang merged 3 commits intohbstack:mainfrom TetraTheta:attr
razonyang merged 3 commits intohbstack:mainfrom
TetraTheta:attr
Conversation
Member
|
The table should already support |
Original code already handled the ID attribute correctly
Contributor
Author
|
I removed the table hook from the PR. Thank you for letting me know about that! |
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added missing
idattribute.Test markdown:
Rendered result:
I only tested with
#idsyntax, but this should also work withid=syntax.