Normalize line-endings#1765
Merged
Merged
Conversation
marcofranssen
requested review from
EItanya,
ilackarms,
iplay88keys,
jmhbh,
peterj,
supreme-gg-gg and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes line endings across a few repository files and introduces a .gitattributes entry to help Git manage text files consistently.
Changes:
- Normalize line endings in a Helm values file and two JS test helper files.
- Add
.gitattributeswith* text=autoto enable Git’s text normalization behavior. - (Incidental) Remove a duplicated YAML key in
values.yaml.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
helm/agents/argo-rollouts/values.yaml |
Line-ending normalization; also removes a duplicated modelConfigRef key. |
.github/data/agent-framework/scenario1/tests/chai-http.js |
Line-ending normalization in scenario test helper. |
.github/data/agent-framework/scenario1/tests/chai-exec.js |
Line-ending normalization in scenario test helper. |
.gitattributes |
Adds repository-wide text normalization rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marcofranssen
force-pushed
the
normalize-lineendings
branch
from
f3bddfd to
ba71da0
Compare
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
force-pushed
the
normalize-lineendings
branch
from
39861ca to
05cf0bf
Compare
EItanya
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of files had a mix of Windows and Linux line-endings, added a
.gitattributesto handle this correctly in the repo and committed the ones with a mix of line endingins.