chore: Deprecate auto-gomaxprocs with natively handles container CPU quotas in GO v1.25#1817
Merged
Merged
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
dongjiang1989
requested review from
EItanya,
ilackarms,
iplay88keys,
jmhbh,
supreme-gg-gg and
yuval-k
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Deprecates the project’s automatic GOMAXPROCS tuning (via go.uber.org/automaxprocs) and removes the internal helper that set GOMAXPROCS at startup, aligning runtime behavior with newer Go container CPU quota handling as referenced in the PR description.
Changes:
- Dropped the
go.uber.org/automaxprocsdependency fromgo.mod/go.sum. - Removed the startup call that auto-sets
GOMAXPROCS. - Deleted the now-unused internal
goruntimehelper package.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/go.sum | Removes checksum entries for automaxprocs and an unused stub dependency. |
| go/go.mod | Drops the explicit go.uber.org/automaxprocs requirement. |
| go/core/pkg/app/app.go | Removes the import and startup call that set GOMAXPROCS. |
| go/core/internal/goruntime/cpu.go | Deletes the internal SetMaxProcs wrapper around automaxprocs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://go.dev/blog/container-aware-gomaxprocs