Skip to content

Storage of Draft package revision resources when mutation pipelines fails#409

Closed
aravindtga wants to merge 9 commits into
kptdev:mainfrom
Nordix:mutation-pipeline-failure-pr-update-render-status
Closed

Storage of Draft package revision resources when mutation pipelines fails#409
aravindtga wants to merge 9 commits into
kptdev:mainfrom
Nordix:mutation-pipeline-failure-pr-update-render-status

Conversation

@aravindtga
Copy link
Copy Markdown
Contributor

@aravindtga aravindtga commented Jan 20, 2026

Description

This PR adds support for persisting the package revision resources and displaying render status when mutation pipeline failures occur when pushing the package revision (Draft->Draft).

  • What changed:

    • Added RenderStatus field to PackageRevision API types (internal and v1alpha1)
    • Implemented RenderStatus persistence in both CR cache and DB cache
    • Updated SQL schema to store render status information (migration scripts included)
    • Enhanced E2E tests to validate render status behavior with function evaluator failures
    • Improved CLI error messages to display render failure information
  • How it works:

    • When mutation pipeline fails, package resources are now stored in git and the failure state updated in package revision
    • RenderStatus (including error messages) is persisted to both CRD status and database
    • CLI commands display detailed render failure messages
    • E2E tests validate pod evaluator failures and recovery scenarios

Related Issue(s)

Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Refactor
  • Documentation
  • Tests
  • Other

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 20, 2026

Deploy Preview for porch ready!

Name Link
🔨 Latest commit 10ff4aa
🔍 Latest deploy log https://app.netlify.com/projects/porch/deploys/698b5da48c6c050008c44272
😎 Deploy Preview https://deploy-preview-409--porch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aravindtga aravindtga force-pushed the mutation-pipeline-failure-pr-update-render-status branch from 07d5cb1 to 17cbca7 Compare January 20, 2026 15:08
@aravindtga aravindtga marked this pull request as ready for review January 20, 2026 15:30
@aravindtga aravindtga self-assigned this Jan 20, 2026
@aravindtga aravindtga added the enhancement New feature or request label Jan 20, 2026
@mozesl-nokia mozesl-nokia mentioned this pull request Jan 22, 2026
12 tasks
@aravindtga aravindtga force-pushed the mutation-pipeline-failure-pr-update-render-status branch 2 times, most recently from b53123a to ab42ed0 Compare January 22, 2026 16:57
@aravindtga aravindtga force-pushed the mutation-pipeline-failure-pr-update-render-status branch 8 times, most recently from d1ed98e to a333301 Compare January 27, 2026 16:24
@aravindtga
Copy link
Copy Markdown
Contributor Author

Documentation should be updated as part of this merge to address this review comment #402 (comment)

This change doesn't update the status of the packagerevision or packagerevisionresources

Signed-off-by: aravind.est <aravindhan.a@est.tech>
Added support for renderStatus in CR and DB cache.
Added RenderStatus field to PackageRevision API types and schemas

Signed-off-by: aravind.est <aravindhan.a@est.tech>
Signed-off-by: aravind.est <aravindhan.a@est.tech>
Signed-off-by: aravind.est <aravindhan.a@est.tech>
Signed-off-by: aravind.est <aravindhan.a@est.tech>
…cache renderstatus

Signed-off-by: aravind.est <aravindhan.a@est.tech>
Signed-off-by: aravind.est <aravindhan.a@est.tech>
Signed-off-by: aravind.est <aravindhan.a@est.tech>
@aravindtga aravindtga force-pushed the mutation-pipeline-failure-pr-update-render-status branch from a333301 to 48762de Compare February 10, 2026 16:12
Signed-off-by: aravind.est <aravindhan.a@est.tech>
@aravindtga aravindtga force-pushed the mutation-pipeline-failure-pr-update-render-status branch from 48762de to 10ff4aa Compare February 10, 2026 16:32
@sonarqubecloud
Copy link
Copy Markdown

@aravindtga aravindtga marked this pull request as draft February 17, 2026 10:12
@aravindtga
Copy link
Copy Markdown
Contributor Author

Different implementation for this feature will be pushed as part of #768.

@aravindtga aravindtga closed this Feb 25, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Nephio Planning Board Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress #ededed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant