Skip to content

feat: second countable finite-dimensional manifolds are sigma-compact#7823

Closed
grunweg wants to merge 1 commit into
masterfrom
MR-manifolds-sigma-compact
Closed

feat: second countable finite-dimensional manifolds are sigma-compact#7823
grunweg wants to merge 1 commit into
masterfrom
MR-manifolds-sigma-compact

Conversation

@grunweg

@grunweg grunweg commented Oct 21, 2023

Copy link
Copy Markdown
Contributor

This uses their local compactness, in particular also requires them to be modelled on a locally compact field.


Likewise, I'm open moving this result to a new file about topological properties of (topological or smooth) manifolds.

@grunweg grunweg added awaiting-review t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters labels Oct 21, 2023
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 21, 2023
@grunweg grunweg force-pushed the MR-manifolds-sigma-compact branch from ec73cbc to dad7619 Compare October 21, 2023 12:33
@digama0

digama0 commented Oct 21, 2023

Copy link
Copy Markdown
Member

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

@grunweg grunweg force-pushed the MR-manifolds-sigma-compact branch from 140dbee to df48927 Compare October 22, 2023 12:54
@grunweg grunweg force-pushed the MR-manifolds-sigma-compact branch from 1ea3c8f to 5227464 Compare October 31, 2023 10:58
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 3, 2023
@ghost

ghost commented Nov 3, 2023

Copy link
Copy Markdown

This PR/issue depends on:

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 3, 2023
@grunweg grunweg force-pushed the MR-manifolds-sigma-compact branch from 5227464 to 7f97bb8 Compare November 3, 2023 16:30
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 3, 2023
@sgouezel

sgouezel commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

I am not convinced this PR is really useful: you can not declare this as an instance as the field k and the model space E can not be guessed by the system by just looking at M, so you would need to invoke the theorem by hand. But at this point you might as well just invoke by hand the theorem that says that M is locally compact (which you have proved in a previous PR), and then typeclass inference will automatically kick in and provide for you the information that M is sigma-compact.

Do you have a use case where you think that the theorem in this PR would be more useful? Maybe I have overlooked some possible application.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 8, 2023
@grunweg

grunweg commented Nov 18, 2023

Copy link
Copy Markdown
Contributor Author

Makes sense! I'm still grappling with the typeclass system - I agree that in given this, this doesn't make sense.

I've checked: for the use case I have in mind (Sard's theorem), invoking local compactness is sufficient. Thanks for the careful look!

@grunweg grunweg closed this Nov 18, 2023
@grunweg grunweg deleted the MR-manifolds-sigma-compact branch December 19, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants