Skip to content

Add --update-lib to gmailctl init#265

Merged
mbrt merged 1 commit into
mbrt:masterfrom
mefuller:init_reset_lib
Jul 1, 2022
Merged

Add --update-lib to gmailctl init#265
mbrt merged 1 commit into
mbrt:masterfrom
mefuller:init_reset_lib

Conversation

@mefuller
Copy link
Copy Markdown
Contributor

@mefuller mefuller commented Jun 24, 2022

Closes #77.

Add --update-lib flag to gmailctl init to allow updating / resetting the gmailct.libsonnet file in users configuration.

Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
@mefuller
Copy link
Copy Markdown
Contributor Author

mefuller commented Jul 1, 2022

I went a tiny bit further and applied the modifications suggested by your comments elsewhere in the file as well

Copy link
Copy Markdown
Owner

@mbrt mbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there, thanks for the patience!

Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go Outdated
Comment thread cmd/gmailctl/cmd/init_cmd.go
Copy link
Copy Markdown
Owner

@mbrt mbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Could you please squash everything together?

@mefuller
Copy link
Copy Markdown
Contributor Author

mefuller commented Jul 1, 2022

All squashed - thanks again

@mbrt mbrt changed the title Init reset lib Add --update-lib to gmailctl init Jul 1, 2022
@mbrt mbrt merged commit 72474e2 into mbrt:master Jul 1, 2022
@mbrt
Copy link
Copy Markdown
Owner

mbrt commented Jul 1, 2022

Thank you!!

@mefuller mefuller deleted the init_reset_lib branch July 4, 2022 09:07
@mbrt mbrt added the kind/feature New feature or request label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gmailctl.libsonnet update

2 participants