Pseudo-cherry pick of ArgSliceVector fixes#1594
Merged
Merged
Conversation
…straight cherry-pick because Namespaces aren't a thing in dev yet
Contributor
There was a problem hiding this comment.
Pull request overview
Reimplements upstream ArgSliceVector safety fixes to avoid returning PinnedSpanByte instances that can become invalid after ScratchBufferBuilder grows its backing buffer, without relying on namespaces being available in this branch.
Changes:
- Switches
ArgSliceVectorstorage fromList<PinnedSpanByte>to storing(Offset, Length)tuples into the scratch buffer. - Updates enumeration to reconstruct
PinnedSpanByteinstances from a snapshot of the scratch buffer at enumeration time. - Adds debug-time guards to discourage mutation during enumeration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TalZaccai
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArgSliceVectorfixes from 6ef5c5c can't be directly picked, since Namespaces aren't a thing yet.Reimplements the change here, since it's more-or-less Vector Set agnostic.