Fix small issues with parse state#1660
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make parse-state growth safer and simpler by centralizing buffer resizing logic into SessionParseState, and using that from transaction key capture.
Changes:
- Replaced manual transaction parse-state buffer growth with a call to
EnsureCapacity. - Removed
CapacityfromSessionParseStateand introducedEnsureCapacity(int)for resizing while preserving contents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/server/Transaction/TxnClusterSlotCheck.cs | Uses centralized EnsureCapacity instead of manual resize/copy logic when saving key slices. |
| libs/server/Resp/Parser/SessionParseState.cs | Removes Capacity and adds EnsureCapacity(int) to safely grow the argument buffer while preserving existing entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vazois
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.