[DEV] Vector Set Migration Reliability Fixes#1706
Merged
kevin-montrose merged 8 commits intoApr 16, 2026
Merged
Conversation
…e bits that 'matter'; which is Dispose order fixing, SessionParseState fixing, and TLS disabling
Contributor
There was a problem hiding this comment.
Pull request overview
Improves reliability of vector set migrations and related cluster scenarios by tightening failure handling in migration scans, adjusting server shutdown sequencing, and adding test-level threadpool tuning.
Changes:
- Abort slot migration when any scan task fails, and stop deleting keys if
TransmitSlots()fails. - Reorder
GarnetServerdisposal to drain/stop servers before disposing the storage provider. - Add test harness threadpool minimum tuning and allow
SimpleSetupClusterto be configured with/without TLS.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Garnet.test.cluster/VectorSets/ClusterVectorSetTests.cs | Forces threadpool mins in test setup; makes cluster setup helper accept useTLS. |
| libs/host/GarnetServer.cs | Reorders shutdown phases so server handlers are drained before provider disposal. |
| libs/cluster/Server/Migration/MigrateSessionSlots.cs | Makes scan tasks return bool and aborts migration when any scan fails; checks TransmitSlots() result. |
| libs/cluster/Server/Migration/MigrateOperation.cs | Checks TransmitSlots() result during namespace key migration and aborts on failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
badrishc
approved these changes
Apr 16, 2026
…cluster tests using SimpleSetupCluster
vazois
approved these changes
Apr 16, 2026
kevin-montrose
deleted the
users/kmontrose/vectorSetMigrationReliabilityClean-dev
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devtargeting version of #1704