Fix capitalization of GitHub org#106808
Closed
ChaseKnowlden wants to merge 5 commits intomasterfrom
unknown repository
Closed
Fix capitalization of GitHub org#106808ChaseKnowlden wants to merge 5 commits intomasterfrom unknown repository
ChaseKnowlden wants to merge 5 commits intomasterfrom
unknown repository
Conversation
ItzLevvie
suggested changes
Sep 15, 2020
| [](https://aka.ms/vscode-builds) | ||
| [](https://github.com/Microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc) | ||
| [](https://github.com/Microsoft/vscode/issues?utf8=✓&q=is%3Aissue+is%3Aopen+label%3Abug) | ||
| [](https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc) |
Contributor
There was a problem hiding this comment.
Suggested change
| [](https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc) | |
| [](https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc) |
Contributor
There was a problem hiding this comment.
Removing this breaks Shield from finding this repository.
Contributor
Author
There was a problem hiding this comment.
i fixed a shield
aeschli
requested changes
Sep 16, 2020
| 34. Microsoft/TypeScript-TmLanguage version 0.0.1 (https://github.com/Microsoft/TypeScript-TmLanguage) | ||
| 35. Microsoft/vscode-JSON.tmLanguage (https://github.com/Microsoft/vscode-JSON.tmLanguage) | ||
| 36. Microsoft/vscode-mssql version 1.9.0 (https://github.com/Microsoft/vscode-mssql) | ||
| 34. microsoft/TypeScript-TmLanguage version 0.0.1 (https://microsoft/TypeScript-TmLanguage) |
|
|
||
| // Strip .git | ||
| assert.deepStrictEqual(getRemotes(remote('https://github.com/Microsoft/vscode.git'), true), ['github.com/Microsoft/vscode']); | ||
| assert.deepStrictEqual(getRemotes(remote('https://github.com/microsoft/vscode.git'), true), ['github.com/icrosoft/vscode']); |
| - Open both `vscode-json-languageservice` and this extension in a single workspace with [multi-root workspace](https://code.visualstudio.com/docs/editor/multi-root-workspaces) feature | ||
| - Run `yarn watch` at `json-languagefeatures/server/` to recompile this extension with the linked version of `vscode-json-languageservice` | ||
| - Make some changes in `vscode-json-languageservice` | ||
| - Now when you run `Launch Extension` debug target, the launched instance will use your development version of `vscode-json-languageservice`. You can interactively test the language features. No newline at end of file |
Contributor
|
I fixed the merge conflicts but didn't had the permission to write back to the fork. Thanks @ChaseKnowlden ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/Microsoft->github.com/microsoft