Skip to content

Added new command to switch between windows#11493

Closed
heycalmdown wants to merge 118 commits into
microsoft:masterfrom
heycalmdown:switch-window
Closed

Added new command to switch between windows#11493
heycalmdown wants to merge 118 commits into
microsoft:masterfrom
heycalmdown:switch-window

Conversation

@heycalmdown
Copy link
Copy Markdown
Contributor

@heycalmdown heycalmdown commented Sep 3, 2016

Adds support to switch between windows.

Switch Window

shows current opened windows in the quick open dialog. Then selecting one shows the window.

It is very needed while making service with TypeScript on the Micro Service Architecture.

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 3, 2016

Hi @heycalmdown, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 3, 2016

@heycalmdown, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 60.979% when pulling 188e480 on heycalmdown:switch-window into 6dff3f6 on Microsoft:master.

@bpasero bpasero self-assigned this Sep 4, 2016
@bpasero
Copy link
Copy Markdown
Contributor

bpasero commented Sep 5, 2016

@heycalmdown thanks. it does not really work though when a window has no workspace associated (= empty window):

image

Then I think the title that we show in this picker should match 100% to the title as it is picked in the window itself. That way a user can correlate easily which window he is about to focus. Similar to how the window shows up in the "Window" menu on Mac.

Also I wonder if this functionality is not already present in the "Open Recent" picker (from the command palette):

image

The difference is that the "open recent" picker contains a history of all folders opened in the past, but the ones that are opened in multiple windows should be to the top.

@bpasero bpasero added this to the Backlog milestone Sep 5, 2016
@bpasero
Copy link
Copy Markdown
Contributor

bpasero commented Sep 6, 2016

@heycalmdown let me know when I should review again

@heycalmdown
Copy link
Copy Markdown
Contributor Author

Oh no. I just messed the history during merge upstream. 😢
What should I do @bpasero? Do you prefer to make another clean PR?

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.9%) to 61.878% when pulling 6da5225 on heycalmdown:switch-window into 6dff3f6 on Microsoft:master.

@heycalmdown
Copy link
Copy Markdown
Contributor Author

I was confused about which is the best practice making new actions, but 0653833 makes things more clearer. Thanks.

@bpasero
Copy link
Copy Markdown
Contributor

bpasero commented Sep 7, 2016

@heycalmdown yes please a clean PR 👍

@heycalmdown
Copy link
Copy Markdown
Contributor Author

@bpasero check the #11630

@heycalmdown heycalmdown closed this Sep 7, 2016
@bpasero
Copy link
Copy Markdown
Contributor

bpasero commented Sep 7, 2016

Thanks.

@heycalmdown heycalmdown deleted the switch-window branch September 20, 2016 07:06
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.