Skip to content

Conversation

@hun1ahpu
Copy link
Contributor

@hun1ahpu hun1ahpu commented Dec 20, 2016

Proposal for #12833.

Next/Prev Group actions circle through existing groups without creating new ones. Similar to behavior in Sublime and Atom.
Fixes the issue when the user is at the last group and NextGroup action does nothing. Same for first group and PreviousGroup action.

@msftclas
Copy link

Hi @hun1ahpu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@bpasero bpasero self-assigned this Dec 21, 2016
@bpasero bpasero mentioned this pull request Dec 21, 2016
@jmdowns2
Copy link
Contributor

Hi hun1ahpu, it looks like we both submitted a PR for #12833 at about the same time. There are 2 scenarios

  1. All 3 groups are open, then Next / Previous should cycle. Both of our PRs address this.

  2. If there are less than 3 groups, should Next Group create a group or cycle?

It looks like your PR does not create a group and just cycles. My PR keeps the creation functionality.

In the original notes for #12833, bpasero indicated that the creation functionality was desired and should not be removed. I guess the question is whether the creation functionality should be preserved or not.

@bpasero
Copy link
Member

bpasero commented Dec 21, 2016

I merged #17625. @hun1ahpu I suggest you bring this PR back to the changes on master to work on the actual change of not opening new groups when using the navigation actions.

I still have to rethink if we want this behaviour to be fair.

@hun1ahpu
Copy link
Contributor Author

No worries. It was just a proposal.
Thanks.

@bpasero bpasero closed this Jan 1, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants