fix: preserve X11 primary selection in quick input (fixes #167266)#301137
Open
locactus wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: preserve X11 primary selection in quick input (fixes #167266)#301137locactus wants to merge 2 commits intomicrosoft:mainfrom
locactus wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Remove auto-generated monaco.d.ts changes that were accidentally included in the previous commit. These type changes are unrelated to the X11 primary selection fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
|
@locactus please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167266
On Linux/X11, quick inputs could overwrite the primary selection buffer because
InputBox.select()always calledthis.input.select()before applying any range-based selection. This keeps full-value selection for the no-range case, but when a range is provided it focuses the input and appliessetSelectionRange(...)directly so the existing X11 primary selection is preserved.Changes
src/vs/base/browser/ui/inputbox/inputBox.tsso full-inputselect()only runs when no selection range is requested.src/vs/platform/quickinput/test/browser/quickinput.test.tsthat covers the reverted quick input focus case when switching from hidden to visible input withvalueSelection.Validation
npm cinpm run compilenpm run eslintnode test/unit/browser/index.js --browser chromium --run src/vs/platform/quickinput/test/browser/quickinput.test.tsgit diff --name-only origin/main...HEADnow contains onlysrc/vs/base/browser/ui/inputbox/inputBox.tsandsrc/vs/platform/quickinput/test/browser/quickinput.test.ts; no config files changed.Review routing
.github/CODENOTIFYroutessrc/vs/platform/quickinput/**to@TylerLeonhardt.