TextureLoader inherits FbxLoader's credentials#31031
Closed
tatsuya-ogawa wants to merge 1 commit into
Closed
Conversation
tatsuya-ogawa
changed the title
Mugen87
reviewed
Apr 30, 2025
|
|
||
| const textureLoader = new TextureLoader( this.manager ).setPath( this.resourcePath || path ).setCrossOrigin( this.crossOrigin ); | ||
| const scope = this; | ||
| const textureLoader = new TextureLoader( this.manager ).setPath( this.resourcePath || path ).setCrossOrigin( this.crossOrigin ).setRequestHeader( scope.requestHeader ).setWithCredentials( scope.withCredentials ); |
Collaborator
There was a problem hiding this comment.
This change has no effect since TextureLoader internally uses ImageLoader and this loader does not use Loader.requestHeader and Loader.withCredentials. These properties are mainly relevant for FileLoader.
Contributor
Author
There was a problem hiding this comment.
@Mugen87 Thank you.
I’d like to use FBXLoader with a closed site that requires authentication, so I want to replace the TextureLoader with one that supports authentication.
Would it be acceptable to add such a mechanism?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I’d like to submit a PR to three.js because the TextureLoader inside FbxLoader isn’t receiving any credentials—this causes errors when loading textures.
so updated it to inherit FbxLoader’s credentials.