Skip to content

doc: esm add example how to create __filename, __dirname #28282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GrosSacASac wants to merge 4 commits into from
Closed

doc: esm add example how to create __filename, __dirname #28282

GrosSacASac wants to merge 4 commits into from

Conversation

@GrosSacASac
Copy link
Contributor

@GrosSacASac GrosSacASac commented Jun 18, 2019

doc: esm add example how to create __filename, __dirname

Checklist
  • tests and/or benchmarks are included (tested manually)
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 18, 2019
addaleax
addaleax approved these changes Jun 19, 2019
View reviewed changes
@addaleax addaleax added the esm Issues and PRs related to the ECMAScript Modules implementation. label Jun 19, 2019
@GrosSacASac
Copy link
Contributor Author

GrosSacASac commented Jun 19, 2019

Do you know what to do with this lint error ?:
751:1-751:38 warning Found unused definition no-unused-definitions remark-lint

lpinca
lpinca reviewed Jun 19, 2019
View reviewed changes
@richardlau
Copy link
Member

richardlau commented Jun 19, 2019

Do you know what to do with this lint error ?:
751:1-751:38 warning Found unused definition no-unused-definitions remark-lint

You've removed the reference to import.meta.url so the linter is complaining that nothing is now referencing the definition on line 751. Either edit to keep the import.meta.url reference or removed the definition from line 751.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 24, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24292/

@GrosSacASac
Copy link
Contributor Author

GrosSacASac commented Jul 10, 2019

fixes #28114

@GrosSacASac
Copy link
Contributor Author

GrosSacASac commented Jul 10, 2019

Should I try to edit the first commit message or can you merge ?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24419/

@lpinca
Copy link
Member

lpinca commented Jul 13, 2019

Landed in 84ad92d.

@lpinca lpinca closed this Jul 13, 2019
@lpinca
Copy link
Member

lpinca commented Jul 13, 2019

@GrosSacASac thank you.

@GrosSacASac GrosSacASac deleted the add-example-dirname-esm branch July 13, 2019 20:25
This was referenced Jul 23, 2019
Closed
Merged
@broofa broofa mentioned this pull request Dec 16, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@guybedford guybedford guybedford approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.