feat: Export common SCSS variables as CSS variables#1620
Conversation
|
Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
23b1e18 to
ab7ec12
Compare
| } | ||
|
|
||
| @each $size, $length in $spacers { | ||
| --png-spacer-#{$size}: #{$length}; |
There was a problem hiding this comment.
| --png-spacer-#{$size}: #{$length}; | |
| --pgn-spacer-#{$size}: #{$length}; |
There was a problem hiding this comment.
This is no longer needed with the most recent changes.
d5837cc to
25ce666
Compare
|
@xitij2000 👍 with the linting issue fixed
|
25ce666 to
1bdb6cb
Compare
Codecov ReportBase: 90.40% // Head: 90.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
=======================================
Coverage 90.40% 90.40%
=======================================
Files 208 208
Lines 3534 3534
Branches 824 824
=======================================
Hits 3195 3195
Misses 324 324
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1bdb6cb to
2823b2c
Compare
|
@xitij2000 Thank you for the contribution. Is this ready for our review? |
Yes. Thanks! |
This commit exports commonly-used SCSS variables as CSS variables as well so that they can be used by MFEs, or other consumers of Paragon, without needing to be rebuilt each time a theme variable changes.
2823b2c to
136c94e
Compare
|
Hi @xitij2000 - is this PR still needed? If so, I can get it reviewed. Looks like it fell off the radar. |
I think this work is overshadowed by the design tokens work going on. I will close this PR for now, and reopen if needed. |
|
@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This commit exports commonly-used SCSS variables as CSS variables as well so
that they can be used by MFEs, or other consumers of Paragon, without needing to
be rebuilt each time a theme variable changes.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist