Skip to content

Upgrade ansible-operator base image to v1.5.0#121

Merged
dymurray merged 1 commit into
openshift:masterfrom
dymurray:aoupgrade
Jun 25, 2021
Merged

Upgrade ansible-operator base image to v1.5.0#121
dymurray merged 1 commit into
openshift:masterfrom
dymurray:aoupgrade

Conversation

@dymurray
Copy link
Copy Markdown
Member

@dymurray dymurray commented Jun 25, 2021

Fixes #102

@dymurray dymurray merged commit 99d1d9c into openshift:master Jun 25, 2021
Comment thread build/Dockerfile
@@ -1,4 +1,4 @@
FROM quay.io/operator-framework/ansible-operator:v0.17.0
FROM quay.io/operator-framework/ansible-operator:v1.5.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if this should point to latest? we do that for mig-operator

https://github.com/konveyor/mig-operator/blob/master/build/Dockerfile#L1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we've been actively moving to use :latest unless we know of a reason we can't.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually going to say we should probably pin mig-operator to a stable release :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had an issue with pinning in past of forgetting to update and then not picking up newer versions that addressed CVEs. The CVEs were the main driver to move us to consume :latest. There was also an impression that ansible-operator has matured so less concern of breaking, and if we did break on a new update good to learn ASAP and catch the issue.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will move to latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thousands of "Skipping cache lookup" messages

4 participants