Fix for Improve DPA additionalPrinterColumns #1659#1668
Fix for Improve DPA additionalPrinterColumns #1659#1668hariprakash619 wants to merge 35 commits into
Conversation
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @hariprakash619. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Thanks @hariprakash619
This needs to be also changed in YAML files. Those files are generated, you can regenerate them with make bundle command
After running it, you can confirm everything is right by running make test command (our CI also runs it)
Could you update PR after running make bundle command?
There was a problem hiding this comment.
Hello @mateusoliveira43 ,
Thank you for the guidance. I am updated the PR after running make bundle which updated the corresponding .yaml file.
There was a problem hiding this comment.
make bundle command should have also updated bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml file (and the changes to config/crd/bases/oadp.openshift.io_dataprotectionapplications.yaml should have been minimal). In which OS are you?
There was a problem hiding this comment.
macOS, Apple M2, version : Sonoma 15.3.1 (24D70).
There was a problem hiding this comment.
I am on Linux
@shubham-pampattiwar @kaovilai can you kelp here?
There was a problem hiding this comment.
@hariprakash619 Once you made changes to the go file, Did you run ?: (in the given sequence)
make generatemake manifestsmake bundle
There was a problem hiding this comment.
Hello @shubham-pampattiwar ,
I created a new folder and set up the git clone again and tried to run the above commands without the newly added changes(JSONPath=".status.conditions[?(@.type=='Reconciled')].status").
I am facing few errors as per the terminal log.
terminal_log.txt
There was a problem hiding this comment.
I think you might have to increase your resources for your system's docker runtime. Error 137 implies OOM.
openshift-merge-robot
added
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hariprakash619 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Tried to help, ended up pushing wrong branch so now this PR has no changes and I guess considered no longer a PR branch I can push to as a maintainer. Reopened under #1674 |
5 participants
Why the changes were made
Fix OADP-1659
Notes:
Replaced
// +kubebuilder:printcolumn:name="Reconciled",type="string",JSONPath=".status.conditions[0].status",description="DataProtectionApplication Reconciled status"
with
// +kubebuilder:printcolumn:name="Reconciled",type="string",JSONPath=".status.conditions[?(@.type=='Reconciled')].status",description="DataProtectionApplication Reconciled status"