Skip to content

Doc fix for BSL/VSL configuration#87

Merged
sseago merged 1 commit into
openshift:masterfrom
sseago:camelcase-bsl
Apr 14, 2021
Merged

Doc fix for BSL/VSL configuration#87
sseago merged 1 commit into
openshift:masterfrom
sseago:camelcase-bsl

Conversation

@sseago
Copy link
Copy Markdown
Contributor

@sseago sseago commented Mar 31, 2021

This makes it clear that BSL/VSL configuration in the OADP Velero CR
must specify Velero parameter names using snake_case rather than
camelCase.

Fixes #80

This makes it clear that BSL/VSL configuration in the OADP Velero CR
must specify Velero parameter names using snake_case rather than
camelCase.

Fixes openshift#80
@sseago
Copy link
Copy Markdown
Contributor Author

sseago commented Mar 31, 2021

@hmuchaku and @gmerigo -- so for both of you, let me know:

  1. Whether specifying s3_url in the Velero CR works for your particular use case without any further code changes
  2. Whether the doc change proposed here makes it clear how to configure this.

@gmerigo
Copy link
Copy Markdown

gmerigo commented Apr 14, 2021

I can confirm point 2, I cannot verify point 1 as our test cluster is currently unavailable, I waited until now to see if we could make any test but I should replicate this on another cluster, unfortunately there we don't have ebs-csi installed so the test would be very different.

@sseago
Copy link
Copy Markdown
Contributor Author

sseago commented Apr 14, 2021

@gmerigo Thanks for the update. I'm going to go ahead and merge this fix. If you try this change in the future and it still fails for you, feel free to open another issue.

@sseago sseago merged commit d3b8b87 into openshift:master Apr 14, 2021
kaovilai added a commit to hariprakash619/oadp-operator that referenced this pull request Mar 19, 2025
Fork Sync: Update from parent repository
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problems with region endpoint URL

3 participants