Disable fact gathering by default#3933
Merged
fabianvf merged 4 commits intoSep 28, 2020
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
fabianvf
force-pushed
the
ansible-disable-default-gathering
branch
from
5028714 to
48e2c98
Compare
fabianvf
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
|
lgtm |
| Eventually(managerContainerLogs, time.Minute, time.Second).Should(ContainSubstring( | ||
| "Ansible-runner exited successfully")) | ||
| Eventually(managerContainerLogs, time.Minute, time.Second).ShouldNot(ContainSubstring("failed=1")) | ||
| Eventually(managerContainerLogs, time.Minute, time.Second).ShouldNot(ContainSubstring("[Gathering Facts]")) |
Contributor
There was a problem hiding this comment.
Oh you are terrific 👍
asmacdo
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
With the migration to kubebuilder style scaffolding, we dropped the
ANSIBLE_GATHERING='explicit'environment variable on the operator's deployment. This causes a performance regression, as gathering facts can increase execution time by 30% for certain playbooks, and the gathered facts do not generally have any applicability to the operator use-case.This also makes it so that when running roles directly, we disable fact gathering if
ANSIBLE_GATHERINGis set to explicit. This allows the user to avoid the aforementioned performance penalty without needing to wrap their role in a playbook.Fixes #2358
Motivation for the change:
Performance regression due to an oversight when migrating to kubebuilder.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs