Change the log message "Skipping cache lookup" from Ansible operator to debug level

[kandaaaaa]

Description of the change:
When we have too many resources to watch, this log message flushing the log and provides no value to us. We lower the log level

If you disagree, please suggest a different way to change

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• Add or update relevant sections of the docs website in website/content/en/docs

[camilamacedo86]

imo we should not remove the log. We need to change its level.

[kandaaaaa]

I tried but seems log does not support debug level. Only Info and Error

[estroz]

You can add debug logging like

log.V(1).Info("Skipping cache lookup", "resource", r)

That 1 indicates a log message that only gets logged when a development logger is used.

[kandaaaaa]

Thanks. I have put to V(2) to align with other lines in the same function. If 1 is really you want. I can make the change again.

[estroz]

I think 2 is ok, although there is a mix of 1's and 2's that should probably be made 1's (helm-operator only uses 1's).

[estroz]

/lgtm

[estroz]

/ok-to-test

[kandaaaaa]

@estroz thanks for getting this approved promptly

[estroz]

/retest

[estroz]

@kandaaaaa these lines are failing in ansible e2e. Debug logging needs to be enabled by passing --zap-devel to the manager, something like the following in test/e2e/ansible/suite_test.go:

var _ = BeforeSuite(func() {

	...

	By("copying sample to a temporary e2e directory")
	Expect(exec.Command("cp", "-r", "../../../testdata/ansible/memcached-operator", tc.Dir).Run()).To(Succeed())

	By("enabling debug logging in the manager")
	err = testutils.ReplaceInFile(filepath.Join(tc.Dir, "config", "manager", "manager.yaml"),
		`- "--leader-election-id=memcached-operator"`,
		"- --leader-election-id=memcached-operator\n            - --zap-devel")
	Expect(err).NotTo(HaveOccurred())

	...
}

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.

[kandaaaaa]

@estroz @camilamacedo86 Fixed the failed test case and update the changelog. Please review again. Thanks

[estroz]

@kandaaaaa there's a broken link that is not the result of your changes. I'll fix it in a separate PR then merge this one.

[kandaaaaa]

@estroz thanks

[estroz]

/retest