Feature/ascii#2115
Conversation
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
Also, please rebase to the upstream master. You currently have a weird merge commit in your PR.
| a :class:`~datetime.datetime` or timestamp. | ||
| If a file was passed, this overrides its mtime. | ||
| """ | ||
| import warnings |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| If a file was passed, this overrides its mtime. | ||
| """ | ||
| import warnings | ||
| if type(filename_or_fp) is str: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| """ | ||
| return td.days * 60 * 60 * 24 + td.seconds | ||
|
|
||
| def is_ascii(string_to_test): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| :returns: True if string_to_test is fully ASCII encoded, False if not | ||
| :rtype: boolean | ||
| """ | ||
| if all(ord(char) < 128 for char in string_to_test): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@ThiefMaster so is it better to delete this branch and create a new updated one? Or do you have any better suggestion? |
|
No, just rebase/amend and then force-push. That will update this PR without adding even more commits. |
|
Why did the checks failed? |
|
There's a syntax error. Please test code before committing/pushing it... |
|
Sorry it was a misunderstood with my colleagues. |
|
Closing because #2223 added support for UTF-8 filenames. |
3 participants
Implemented the solution purposed by @dsully for issue #1286