Fix including test data#1113
Merged
Merged
Conversation
csmarchbanks
left a comment
csmarchbanks
left a comment
Member
There was a problem hiding this comment.
Thanks! LGTM but you need to sign the DCO before I can merge.
Readd parts of `MANIFEST.in` responsible for including the test data in the source distribution. Without that, setuptools includes only `.py` files from the test tree, leading to test failures. Fixes prometheus#1112 Signed-off-by: Michał Górny <mgorny@gentoo.org>
mgorny
force-pushed
the
missing-test-data
branch
from
53447f3 to
02ecd1f
Compare
Contributor
Author
|
Sorry about that. Force-pushed now. |
csmarchbanks
approved these changes
Jun 12, 2025
csmarchbanks
left a comment
csmarchbanks
left a comment
Member
There was a problem hiding this comment.
No worries, thanks again!
Member
|
One other question, do you need a patch release for this immediately, or are you ok waiting until the next minor release since it is only tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readd parts of
MANIFEST.inresponsible for including the test data in the source distribution. Without that, setuptools includes only.pyfiles from the test tree, leading to test failures.Fixes #1112