gh-129539: Include sysexits.h before checking EX_OK#129540
gh-129539: Include sysexits.h before checking EX_OK#129540collinfunk wants to merge 1 commit intopython:mainfrom collinfunk:sysexits-redefinition
Conversation
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks! LGTM.
cc @vstinner as the person who wrote the code.
Previously the macro would be redefined when the header was included.
|
Thanks, your change is correct. But I was fed up of such bugs so I wrote a big refactoring change to reduce the risk of such bug: #129558 Your change remains relevant for 3.13 branch. Can you try to create a new PR for 3.13? Thanks. |
|
GH-129590 is a backport of this pull request to the 3.13 branch. |
Sounds good to me. Thanks!
I created #129590. Not used to the Python pull request workflow so sorry in advance for any mistakes. :) |
|
GH-129590 is a backport of this pull request to the 3.13 branch. |
Previously the macro would be redefined when the header was included.