Skip to content

gh-129539: Include sysexits.h before checking EX_OK#129540

Closed
collinfunk wants to merge 1 commit intopython:mainfrom
collinfunk:sysexits-redefinition
Closed

gh-129539: Include sysexits.h before checking EX_OK#129540
collinfunk wants to merge 1 commit intopython:mainfrom
collinfunk:sysexits-redefinition

Conversation

@collinfunk
Copy link
Copy Markdown
Contributor

@collinfunk collinfunk commented Feb 1, 2025

Previously the macro would be redefined when the header was included.

@ghost
Copy link
Copy Markdown

ghost commented Feb 1, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

Comment thread Misc/NEWS.d/next/Build/2025-01-31-19-01-24.gh-issue-129539.6ndioH.rst Outdated
Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

cc @vstinner as the person who wrote the code.

Comment thread Modules/posixmodule.c Outdated
Previously the macro would be redefined when the header was included.
@collinfunk collinfunk requested a review from vstinner February 1, 2025 21:41
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 2, 2025

Thanks, your change is correct. But I was fed up of such bugs so I wrote a big refactoring change to reduce the risk of such bug: #129558

Your change remains relevant for 3.13 branch. Can you try to create a new PR for 3.13? Thanks.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Feb 2, 2025

GH-129590 is a backport of this pull request to the 3.13 branch.

@collinfunk
Copy link
Copy Markdown
Contributor Author

Thanks, your change is correct. But I was fed up of such bugs so I wrote a big refactoring change to reduce the risk of such bug: #129558

Sounds good to me. Thanks!

Your change remains relevant for 3.13 branch. Can you try to create a new PR for 3.13? Thanks.

I created #129590. Not used to the Python pull request workflow so sorry in advance for any mistakes. :)

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Feb 2, 2025

GH-129590 is a backport of this pull request to the 3.13 branch.

@vstinner vstinner closed this Feb 2, 2025
@collinfunk collinfunk deleted the sysexits-redefinition branch February 3, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants