Skip to content

[WIP] bpo-42213: Support cyclic garbage collection in sqlite3 #23046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erlend-aasland wants to merge 1 commit into from
Closed

[WIP] bpo-42213: Support cyclic garbage collection in sqlite3 #23046

erlend-aasland wants to merge 1 commit into from

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 30, 2020 •
edited by bedevere-bot
Loading

For sqlite3.Connection and sqlite3.Cache:

  • Get rid of old decref_factory hack
  • Support cyclic GC in both types

Skipping NEWS should be fine for this, I guess.

@berkerpeksag, would you mind reviewing this?

https://bugs.python.org/issue42213

@erlend-aasland erlend-aasland marked this pull request as draft October 30, 2020 22:20
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Oct 30, 2020

Unit tests are failing on Windows. Further investigation needed.

@Bobble74
Copy link

Bobble74 commented Oct 31, 2020

192.168.43.42.1

@erlend-aasland erlend-aasland changed the title bpo-42213: Support cyclic garbage collection in sqlite3 [WIP] bpo-42213: Support cyclic garbage collection in sqlite3 Nov 17, 2020
@github-actions
Copy link

github-actions bot commented Dec 18, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 18, 2020
Support cyclic garbage collection in sqlite3
ba1a906 
For sqlite3.Connection and sqlite3.Cache:
- Get rid of old cyclic GC hack
- Support cyclic GC in both types
@erlend-aasland erlend-aasland mentioned this pull request Jan 12, 2021
Merged
@erlend-aasland erlend-aasland deleted the bpo-42213 branch May 29, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @Bobble74 @the-knights-who-say-ni @bedevere-bot