Skip to content

bpo-32642: adding compatibility for pathlike objects in sys.path #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jayyyin wants to merge 6 commits into from
Closed

bpo-32642: adding compatibility for pathlike objects in sys.path #5691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0fcc5ac
adding compatibility for pathlike objects in sys.path
jayyyin Feb 15, 2018
18ee5c2
fixed indentation
jayyyin Feb 15, 2018
775fce2
added news file
jayyyin Feb 15, 2018
39f804c
remade importlib h file
jayyyin Mar 5, 2018
481347b
rebasing importlib_external.h
jayyyin Mar 8, 2018
4a340ec
remade importlib_external.h after rebase
jayyyin Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/importlib/_bootstrap_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,6 +1241,8 @@ def _get_spec(cls, fullname, path, target=None):
# the list of paths that will become its __path__
namespace_path = []
for entry in path:
if hasattr(entry, '__fspath__'):
Copy link
Copy Markdown
Member

@brettcannon brettcannon Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary as os.fspath() passes strings through without issue.

entry = _os.fspath(entry)
if not isinstance(entry, (str, bytes)):
continue
finder = cls._path_importer_cache(entry)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-02-15-12-52-34.bpo-32642.e4g57h.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
adding compatibility for pathlike objects in sys.path
Copy link
Copy Markdown
Member

@brettcannon brettcannon Apr 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
adding compatibility for pathlike objects in sys.path
Add compatibility for path-like objects on sys.path.
Patch by jayyin.

Loading