Skip to content

Conversation

@singhvikash11
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
guardian ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 9:49AM (UTC)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3495864813

  • 0 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 74.574%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/appeal/service.go 0 3 0.0%
api/handler/v1beta1/approval.go 0 29 0.0%
Totals Coverage Status
Change from base Build 3488274545: -0.3%
Covered Lines: 6121
Relevant Lines: 8208

💛 - Coveralls

@ravisuhag
Copy link
Member

@singhvikash11 Slack for approvals etc. should act like a client only. We should not club it with the server code. Can you first describe and discuss your approach on an issue. So that we are aligned on approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants