Set all crates to 2021 edition#580
Merged
Merged
Conversation
Thomasdezeeuw
approved these changes
Aug 20, 2023
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but the CI is failing.
nyurik
force-pushed
the
edition
branch
7 times, most recently
from
65b5c05 to
f9a6daa
Compare
Contributor
Author
|
It took a few tries, but I think I fixed all the outstanding issues with this one. As the result, 50 less lines of code, and a few extra CI checks. |
Thomasdezeeuw
approved these changes
Aug 20, 2023
Contributor
|
Thanks for doing some much needed housekeeping @nyurik! It looks like we just have some conflicts to resolve now. |
Contributor
Author
|
thx @KodrAus, rebased & fixed |
Contributor
Author
|
@KodrAus hi, would you be the right person to review? I would like to make a few more improvements like use workspaces, but all other changes would be based on this one, so I don't want to make them until this is agreed on & merged. Thx! |
Contributor
|
Merged! Thanks again @nyurik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason all crates still use 2015 edition. I think it is a good idea to specify edition explicitly, or at least document why it should be kept back (and still add it to the cargo.toml for documentation purposes)
extern crateuse self::sval::...touse sval::..., and the same forsval_reffn get<'v>(&'v self, key: Key) -> Option<Value<'v>>tofn get(&self, key: Key) -> Option<Value<'_>>