Add feature to set path-based visibility of macro_rules to pub by default #149337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
implicit-pub-macros
branch
from
abaf5eb to
6be80a1
Compare
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
implicit-pub-macros
branch
from
6be80a1 to
34baa79
Compare
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
implicit-pub-macros
branch
from
34baa79 to
db51cee
Compare
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
implicit-pub-macros
branch
2 times, most recently
from
e49dfe5 to
600e45b
Compare
This comment has been minimized.
This comment has been minimized.
yaahc
force-pushed
the
implicit-pub-macros
branch
4 times, most recently
from
3c85396 to
2670d21
Compare
rustbot
added
S-waiting-on-review
yaahc
force-pushed
the
implicit-pub-macros
branch
5 times, most recently
from
eea03df to
9853d97
Compare
yaahc
force-pushed
the
implicit-pub-macros
branch
from
9853d97 to
0d1557a
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
Could you enable this new behavior without a |
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experiment for #148610
This change takes advantage of the fact that
macro_rulescannot be resolved via path-based scope by default1, letting us change their implicit visibility without changing their reach-ability from dependent crates for all existing stable code.TODO
@petrochenkov the PR is split into two commits. The first adds tests that show the current behavior, the second implements the feature, modifies the tests to take advantage of the new feature, and adds a feature gate test.
Footnotes
https://github.com/rust-lang/reference/pull/2055/files#diff-6ea1ee99d6fb8818703d2bd8bf5d373182871235ea102d2de541af0dd87d20bbR368-R374 ↩