cg_llvm: Add noreturn attribute to inline assembly marked as noreturn #150226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
A-LLVM
wesleywiser
reviewed
Jan 15, 2026
| attrs.push(llvm::MemoryEffects::ReadOnlyNotPure.create_attr(self.cx.llcx)); | ||
| } | ||
|
|
||
| if options.contains(InlineAsmOptions::NORETURN) { |
Member
There was a problem hiding this comment.
I think we also need to check there are no labels right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline assembly marked with
options(noreturn)isn't actually annotated with LLVM'snoreturnattribute, which can cause extra instructions to be generated:currently generates
Other options are mapped to their respective LLVM attributes, so this seems like an oversight.